Plone 5.1rc2 soft-released

I'd say that a 'go' for 5.1rc2 unless we can finally get a new release of ZEO in before 'unpending' it.

Zeo release just came through. I’ll get the release updated.

Has 'Display publication date' disappeared ?

When enabling it (in the control panel), it shows for listing, but not below (page etc) document title.

… or is there another setting to enable it?

I see the same at http://demo.plone.de/en/demo/a-page

Zeo 5.1.1 has been added to the release.

I can confirm that undo now works. I think we make a release.

@espenmn: Displaying the byline is controlled by the setting plone.allow_anon_views_about in http://demo.plone.de/@@security-controlpanel
The date which should be used is controlled in the setting plone.display_publication_date_in_byline http://demo.plone.de/@@site-controlpanel

After some digging around, I found that it has been removed from the 'theme' for quite a while, looks like I need to add it with diazo (or another way (?) )

UPDATE: I discovered it is 'the other way around: it will show if you are NOT logged in. If you are logged in you can (usually) see it in the toolbar.

I don't see that (this is on my test site with default theme and about everything by default)

When logged in, a page or an image always have author and modification dates in the byline. A folder never displays anything in the byline

When not logged in the rules are more complicated.

  1. If the 2 checkboxes are set
    a folder has author, last modification and publication date
    a page or an image have author and last modification date
    there is some strange behaviour about the publication date for a folder; it does not seem to display immediately after the site checkbox has been set, but only after clicking a few times on the folder.

  2. if the Site checkbox if cleared (Security box left checked)
    a folder, a page or an image have all author and last modification date

  3. if the Security checkbox if cleared nothing is displayed

The publication date erratic display is a bit confusing; also the fact that the 2 checkboxes have absolutely no effect when logged in is not really obvious.

@espenmn @gp54321 the issue with the byline is very old and caused very heated discussions in the past; what you see right now is the result of partially reverting to the original behavior in Plone 4 and below; you can learn about it here:

if you think the byline has to work on a different way, please open an issue describing the expected behavior so we can work around it.

I've removed the pending tag and passed the build onto the installers team. Point your buildouts at http://dist.plone.org/release/5.1rc2/ and we'll have installers shortly.

1 Like

@pbauer I'm getting error 502 on http://demo.plone.de

Merry Xmas! :smile: :christmas_tree: :menorah:

And the installers are done. I've published the release page at https://plone.org/download/releases/5.1rc2

Thanks for the release! I updated https://github.com/starzel/buildout and http://demo.plone.de is up again.

Also there is still a 502 during the 4-hourly reset of the site. I still did not fix https://github.com/collective/demo.plone.de/issues/20. Lazy me.

Ah! OK.

Yeah, come on! What have you done for Plone lately! :smiley:

FYI: I just upgraded plone.restapi to use Plone 5.1rc2 and the test process get stuck both locally and on Travis with:

ZODB.POSException.ReadConflictError: '"G\xcd-\xef\xfb(\xc3'

See Travis for the full trace:

https://travis-ci.org/plone/plone.restapi/jobs/322687594

Potentially related: We have a nightly of our 4.3 product running against git masters of plone.rest and plone.restapi. It has been failing since the 22nd, but we've not had time to chase that yet as the error we're getting is masked by how the test in question runs.

Traceback (most recent call last):
  File "bin/test", line 428, in <module>
    sys.exit(collective.xmltestreport.runner.run_internal(['-s', 'opengever', '--exit-with-status', '--auto-color', '--auto-progress', '--xml', '--package-path', '/home/jor/opengever.core/opengever', 'opengever']))
  File "/home/jor/opengever.core/eggs/collective.xmltestreport-1.3.3-py2.7.egg/collective/xmltestreport/runner.py", line 77, in run_internal
    runner.options.output.writeXMLReports()
  File "/home/jor/opengever.core/eggs/collective.xmltestreport-1.3.3-py2.7.egg/collective/xmltestreport/formatter.py", line 287, in writeXMLReports
    outputFile.write(prettyXML(testSuiteNode).decode('utf-8'))
  File "/home/jor/opengever.core/eggs/collective.xmltestreport-1.3.3-py2.7.egg/collective/xmltestreport/utils.py", line 42, in prettyXML
    return ElementTree.tostring(tree)
  File "/home/jor/.pyenv/versions/2.7.14/lib/python2.7/xml/etree/ElementTree.py", line 1126, in tostring
    ElementTree(element).write(file, encoding, method=method)
  File "/home/jor/.pyenv/versions/2.7.14/lib/python2.7/xml/etree/ElementTree.py", line 820, in write
    serialize(write, self._root, encoding, qnames, namespaces)
  File "/home/jor/.pyenv/versions/2.7.14/lib/python2.7/xml/etree/ElementTree.py", line 939, in _serialize_xml
    _serialize_xml(write, e, encoding, qnames, None)
  File "/home/jor/.pyenv/versions/2.7.14/lib/python2.7/xml/etree/ElementTree.py", line 939, in _serialize_xml
    _serialize_xml(write, e, encoding, qnames, None)
  File "/home/jor/.pyenv/versions/2.7.14/lib/python2.7/xml/etree/ElementTree.py", line 937, in _serialize_xml
    write(_escape_cdata(text, encoding))
  File "/home/jor/.pyenv/versions/2.7.14/lib/python2.7/xml/etree/ElementTree.py", line 1073, in _escape_cdata
    return text.encode(encoding, "xmlcharrefreplace")
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 467: ordinal not in range(128)

Since the 28th that particular trace went away, but the nightly in question still fails. I'm unsure if that nightly of ours just broke, though.

I'm suspecting this is the same thing as G\xcd-\xef\xfb(\xc3 is containing 0xc3 and that's on the superficial layer of our stack trace.

I suspect the error while reporting the error would be fixed by https://github.com/collective/collective.xmltestreport/pull/18

I checked out Matthew's branch and it did not solve the problem. The same issue actually occurs on 5.1rc1 as well. I started removing tests that run before the deadlock and this just leads to more ReadConflictErrors .

Oh, I didn't expect Matthew's branch to solve the main problem, just fix the UnicodeDecodeError while reporting the test result. I don't know what causes the ReadConflictError but I have a hunch it is some interaction between our upgrade to ZODB 5 and plone.testing's stacked databases.

Ok. I misunderstood your previous message then. The problem actually already occurs when upgrading to Plone 5.1b4. I created an issue in the plone.restapi tracker (even though I don't think the problem has anything to do with plone.restapi itself):

Turned out using freezegun in the plone.restapi test_documentation tests together with the upgrade to Plone 5.1b4 is causing the problem.