Plone 5.1rc1 soft-released

Development
1

Plone 5.1rc1 has been soft-released. Please give it a try and let me know if there are any critical issues. http://dist.plone.org/release/5.1rc1-pending/versions.cfg

For those who haven't run across soft-releases before, this is the
last step before the final release. Because things haven't been
finalized yet, some packages may change between now and the release. It
is not recommended to use soft-releases in production.

4 Likes
2

Attempted an upgrade from 5.1a2 to 5.1rc1 and it failed

Upgrade aborted. Error:
Traceback (most recent call last):
  File "/home/ubuntu/workspace/eggs/Products.CMFPlone-5.1rc1-py2.7.egg/Products/CMFPlone/MigrationTool.py", line 268, in upgrade
    step['step'].doStep(setup)
  File "/home/ubuntu/workspace/eggs/Products.GenericSetup-1.8.8-py2.7.egg/Products/GenericSetup/upgrade.py", line 166, in doStep
    self.handler(tool)
  File "/home/ubuntu/workspace/eggs/plone.app.upgrade-2.0.7-py2.7.egg/plone/app/upgrade/v51/betas.py", line 188, in move_safe_html_settings_to_registry
    settings = registry.forInterface(IFilterSchema, prefix='plone')
  File "/home/ubuntu/workspace/eggs/plone.registry-1.1.2-py2.7.egg/plone/registry/registry.py", line 82, in forInterface
    name
KeyError: 'Interface `Products.CMFPlone.interfaces.controlpanel.IFilterSchema` defines a field `valid_tags`, for which there is no record.'
End of upgrade path, main migration has finished.
The upgrade path did NOT reach current version.
Migration has failed

I ended up first upgrading to 5.1b4 (configuration 5107)

Attempting an upgrade from 5107 to 5108 still failed with the same error as above.

3

We should add a version-pinn for enum34 which is a dependency for pyScss:

enum34 = 1.1.6
4

I found another case of not yet registered safe_html settings when migrating 5.0.8 to 5.1rc1. Fixed with https://github.com/plone/plone.app.upgrade/pull/135

Actually it is the same that @pigeonflight found.

5

Merged!

2 Likes
6

Will test as soon as the updated plone.app.upgrade is released.

7

Is it by intend/ with reason, that the Mosaic dependencies are outdated in the RC1?

8

We might consider updating ZODB to 5.3.0. I run into this issue with the currentyl pinned 5.2.4 https://github.com/zodb/relstorage/issues/191.

1 Like
9

There is another issue with plone.app.iterate: https://github.com/plone/plone.app.upgrade/pull/136
As I mention in the PR we probably need another upgrade-step for cases when the the registry holds a unicode-value and we only run migrations from 5.0.x to 5.1.x. I may have time to test that on thursday.

10

Also there is this issue with CMFDefault: https://github.com/plone/Products.CMFPlone/issues/2141

11

If someone can give me the correct versions for the mosaic packages, or update the 5.1 versions.cfg, I'll make sure that's added to the release.

12

Added this and the enum34 pin. I'll update the release as soon as the tests are done.

13

@esteele please review those two fixes - I think they are needed for the 5.1rc1 release:


14

I tested 5.1 rc1 this morning but I've some strange issues.

Firt: I was forced to add some low level eggs to ignores settings for the omelette buildout recipe due to strange errors:

[omelette]
recipe = collective.recipe.omelette
eggs = ${instance:eggs}
ignores =
    olefile
    roman
    Unidecode

After fixing this the buildout runs and Zope starts but then I've a lot of exception captured by PDBDebugMode:

BadRequest: ('Empty or invalid id specified', u'temp_folder')
> /Users/keul/Library/Buildout/eggs/Zope2-2.13.26-py2.7.egg/OFS/ObjectManager.py(94)checkValidId()
-> raise BadRequest, ('Empty or invalid id specified', id)
(Pdb) !id
u'temp_folder'
(Pdb) l
 89  	    import Globals  # for data
 90
 91  	    if not id or not isinstance(id, str):
 92  	        if isinstance(id, unicode):
 93  	            id = escape(id)
 94  ->	        raise BadRequest, ('Empty or invalid id specified', id)
 95  	    if bad_id(id) is not None:
 96  	        raise BadRequest, (
 97  	            'The id "%s" contains characters illegal in URLs.' % escape(id))
 98  	    if id in ('.', '..'): raise BadRequest, (
 99  	        'The id "%s" is invalid because it is not traversable.' % id)

Here id is an unicode instead of a string, so I get the error.
Switching back to 5.1b4 fix the problem.

I'm the only one with this problem?

15

@keul
I also got this error.
On buildout.coredev it's already solved.
See this discussion: https://github.com/plone/Products.CMFPlone/issues/2156#issuecomment-332164210

1 Like
16

I've updated the release on dist.plone.org with the new version pins.

2 Likes
17

I checked the new pinns against a 5.0.8 project and the upgrade to 5.1rc1 was without issues.

18

Fantastic. Thanks @pbauer. I've removed the -pending flag.

2 Likes
19

Thanks! https://github.com/starzel/buildout now supports 5.1rc1

20

The upgrade now runs successfully, but when I attempt to visit a newsitem I get:

Traceback (innermost last):
  Module Products.PloneFormGen.patches, line 21, in safe_render
  Module Products.Five.browser.pagetemplatefile, line 125, in __call__
  Module Products.Five.browser.pagetemplatefile, line 59, in __call__
  Module zope.pagetemplate.pagetemplate, line 137, in pt_render
  Module five.pt.engine, line 98, in __call__
  Module z3c.pt.pagetemplate, line 163, in render
  Module chameleon.zpt.template, line 261, in render
  Module chameleon.template, line 191, in render
  Module chameleon.template, line 171, in render
  Module 0feff6079554efdf190e82e6877d2623.py, line 320, in render
  Module five.pt.expressions, line 161, in __call__
  Module plone.portlet.static.static, line 183, in transformed
  Module Products.PortalTransforms.TransformEngine, line 171, in convertTo
  Module Products.PortalTransforms.chain, line 45, in convert
  Module Products.PortalTransforms.Transform, line 196, in convert
  Module Products.PortalTransforms.transforms.safe_html, line 2390, in convert
  Module plone.registry.registry, line 82, in forInterface
KeyError: 'Interface `Products.CMFPlone.interfaces.controlpanel.IFilterSchema` defines a field `valid_tags`, for which there is no record.'

 - Expression: "view/transformed"
 - Filename:   ... et.static-3.1.1-py2.7.egg/plone/portlet/static/static.pt
 - Location:   (line 21: col 36)
 - Source:     ... v tal:replace="structure view/transformed" />
                                            ^^^^^^^^^^^^^^^^
... snip ...

TransformError: Error during transformation

 - Expression: "python:context.text.output_relative_to(view.context)"
 - Filename:   ... egg/plone/app/contenttypes/browser/templates/newsitem.pt
 - Location:   (line 15: col 29)
 - Source:     ... ucture python:context.text.output_relative_to(view.context)"
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This is similar to the error that was preventing the upgrade from running which also made reference to:

KeyError: 'Interface `Products.CMFPlone.interfaces.controlpanel.IFilterSchema` defines a field `valid_tags`, for which there is no record.'