Plone 5.1rc1 soft-released

pigeonflight · October 1, 2017, 10:38am

Following a hunch I decided to visit {mysite}/@@filter-controlpanel
and, confirming my hunch, I got the same error:

'Interface Products.CMFPlone.interfaces.controlpanel.IFilterSchema defines a field valid_tags, for which there is no record.'

Conclusion

This is related to HTML filtering now being managed by the configuration registry but some critical fields not "getting" into the registry after the upgrade.

pigeonflight · October 1, 2017, 11:14am

Just noting this here for others (and my future self). It seems that HTML filitering is now managed via the configuration registry.

See the code that defines the IFilterSchema below:

github.com

plone/Products.CMFPlone/blob/master/Products/CMFPlone/interfaces/controlpanel.py#L342-L456


    title=_(u'Choose the CSS used in WYSIWYG Editor Area'),
    description=_(u'This option enables you to specify a custom CSS file '
                  'that provides content CSS. '
                  'This CSS file is the one used within the editor '
                  '(the editable area). In addition to what is listed, '
                  'here the plone bundle CSS and diazo themes using the '
                  'tinymce-content-css setting are also added.'),
    value_type=schema.TextLine(),
    missing_value=[],
    default=[
        u'++plone++static/components/tinymce/'
        u'skins/lightgray/content.min.css'
    ],
    required=False)


header_styles = schema.List(
    title=_(u'Header styles'),
    description=_('Name|tag'),
    value_type=schema.TextLine(),
    missing_value=[],

This file has been truncated. show original

The upgrade steps to Plone 5.1rc1 don't currently "activate" the 'valid_tags' or 'custom_attributes' fields, from the IFilterSchema, in the configuration registry.

For now, my workaround was to manually import an .xml file which brings in all of the IFilterSchema.

Taking inspiration from https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/profiles/dependencies/registry.xml, I created an xml file called filterschema.xml with the following content

<?xml version="1.0"?>
<registry>
  <records interface="Products.CMFPlone.interfaces.IFilterSchema"
           prefix="plone" />
  </registry>

Then I imported it by visiting {mysite}/portal_registry > import and attaching and importing the filterschema.xml file.

Now when I visit {mysite}/@@filter-controlpanel it works and, more importantly, my news items are no longer breaking due to missing IFilterSchema records.

keul · October 3, 2017, 11:08am

Sorry again guys.

Today switched to non-pending rc1. The main issue above disappeared but I still need to keep this omelette configuration or I can't run my buildout.

[omelette]
recipe = collective.recipe.omelette
eggs = ${instance:eggs}
ignores =
    olefile
    roman
    Unidecode

Isn't omelette a common/suggested toy these days?

jaroel · October 3, 2017, 8:22pm

Hi,

I'm running into a broken build due to object indexing problems on 5.1 latest.
By pinning Products.CMFCore back to 2.2.11 instead of 2.2.12 our build does pass.

I don't have a small reproducible test case though. I suspect that the zope.proxy based implementation in Products.CMFCore.indexing is somehow different in practice.

-Roel

pbauer · October 4, 2017, 6:58am

@jaroel did you check https://github.com/plone/documentation/blob/5.1/develop/addons/upgrade_to_51.rst#assimilate-collectiveindexing?

jaroel · October 4, 2017, 10:00am

That does indeed fix that testcase!

pbauer · October 4, 2017, 10:19am

Great! Upgrade-guides FTW. The inconvenient thing is that we do not publish it before the final release...

pigeonflight · October 7, 2017, 8:38am

Just noting that I was not able to reproduce the issue on a second website. On the second site the error presents itself when the new software has been activated through buildout but BEFORE upgrade steps have been run (thankfully we test upgrades on a copy of the live site). This means we probably can't do an in-place upgrade by running bin/buildout as there will be a "window" of time where the site has the new software but the upgrade steps have not been activated.