Python 3, plone.api, read (blob) image

Plone Support Customizing Plone
,
1

When porting to python 3, I run into (another) unicode error.
This works with python 2.7, but in python 3 'return NamedBlobImage' gives error:

*** UnicodeDecodeError: 'utf-8' codec can't decode byte 0x89 in position 0: invalid start byte

filename is a string, like: '/Users/me/Plone52/zinstance/src/my.theme/src/my.theme/theme/favicon.png'

from plone import api
import os
from plone.namedfile.file import NamedBlobImage

....
....

icon_image.image = load_image(i_image)

def load_image(i_image):
    filename = os.path.join(os.path.dirname(__file__), 'theme',
                        i_image)
    return NamedBlobImage(
        data=open(filename, 'r').read(),
       filename=u'{0}'.format(i_image)
    )
2

Open the file for reading in binary mode, not in text mode

3

Great, thank.

For later reference:

return NamedBlobImage(
  data=open(filename, 'rb').read(),
 filename=u'img-{0}'.format(i_image)
)
4

Any your code will likely raise a ResourceWarning under Python 3 when you inline open and read the file. Use a context manager or properly open and close the file.