Products.PortalTransforms.data.datastream.getData() changes?

alert · October 18, 2018, 8:56pm

The quick fix is to change collective.cover's code here:

collective/collective.cover/blob/f6255b031517a37c4ca4c3d9adb3fd5116364f0d/src/collective/cover/tiles/richtext.py#L101


    return ''


transforms = api.portal.get_tool('portal_transforms')
data = transforms.convertTo(
    'text/plain',
    value.encode('utf-8 ') if isinstance(value, six.text_type) else value.raw_encoded,
    mimetype='text/html',
    context=context,
    encoding='utf-8' if isinstance(value, six.text_type) else value.encoding)


searchable_text = six.text_type(data.getData(), 'utf-8')
return searchable_text.strip()  # remove leading and trailing spaces

searchable_text = data.getData()
if isinstance(searchable_text, six.binary_type):
    searchable_text = searchable_text.decode('utf-8')

or

from Products.CMFPlone.utils import safe_unicode
return safe_unicode(data.getData())

Unluckily the output of convertTo has changed in a non retrocompatible way in a minor release and nobody noticed this.

Apparently convertTo should return a str object in both Python 2 and 3.

That is very bad and I am sorry it happened but it is good that now we know.
Not really sure how to fix this easily and in a fast way upstream.