The automatic wrapping by just setting compile to false is not working as expected.
I was debuggin this this week to find out why, but so far the code is still a bit confusing and does not make sense to me in all cases.
The expectation is, that hen i register only a bundle without extra resources and set compile to False, that 1. it will not be compiled and 2. it should be wrapped to deactivated/activate requirejs. The last step is not happening. First of all, the code tells me that it can't work without an extra resource. Than when there is not resource defined for the bundle it skips the wrapping at all. But even with a resource, it want work for me. Need more digging. Maybe @thet we could have a look together on this soon.
I'm not sure if this was intended, we talked about these changes and said that it should go into Plone 6, not 5.2. As small as they are, these are features. But I'm ok if it stays, compared to the changes on the zope level, the risks are small.
plone.app.theming: 4.0.4 → 4.1.1
New features:
Insert diazo bundle without rules.
[santonelli] (#176)
Add custom CSS settings and view to theming control panel.
Ddepends on https://github.com/plone/Products.CMFPlone/pull/3089
[MrTango] (#178)
I have had vacation, and then a few non-Plone days (Django, Flask). Now I am back and see that much has been fixed. Thanks a lot!
Many small but welcome fixes, a lot of them for translations and UI fixes. But biggest is Zope 4.5. That should fix various problems with page templates.
I have updated https://dist.plone.org/release/5.2.2-pending.
Note that the files there are cached, which is useful, except for versions.cfg (and constraints.txt). If near the top you see an extends of Zope 4.5, then you have the correct version. Otherwise add something like versions.cfg?yourname=1 to the url to avoid the cache.
Has anyone tried tinyMCE image captioning in 5.2.2?
I failed to do a rigorous before-and-after test on my build, and behold, when I go to TinyMCE and try to 'include caption with image' I don't see the option. And it's been months since I played with it.
If it is there, can someone screenshot it?
Our imported content is showing captions, so the resolveuid-and-caption transform is doing it's job on our system.
Update: it was my fault. I had plone.staticresources pinned at 1.2.0 in my buildout.
We (@nilshofer my intern and I) are trying to make things work on Windows again are making good progress. The branch is here:
And it has an Github Action to test if buildout runs on window, macos and linux with the different Python versions 2.7, 3.6-3.8):
@mauritsvanrees There are changes in collective.recipe.omelette and zope.sendmail and a change in requirements.txt and in core.cfg (not release relevant, but probably for the Installer) I would like to get into the 5.2.2 release.
With those in, buildout works in Windows 10 in an Administrator Powershell.
At the moment we are struggling with plone.recipe.zope2instance and its usage of zdaemon. We may need to invoke waitress directly if we can not get it fixed.
We also already touched the Installer and merged a PR there. But maybe more work need to be done there.
Update: Since plone.recipe.zope2instance uses zdaemon - which is not supposed to work on Windows - its completly broken. Bug Report:
To me this is is a critical problem. We now try to move around this by using waitress directly w/o the paste.server_factory = plone.recipe.zope2instance:main.
run pip: .\py\Scripts\pip.exe -U pip and .\py\Scripts\pip.exe -r requirements.txt
run buildout: .\py\Scripts\buildout.exe
it case of PermissionErrors just re-run buildout. Those are random and something Windows specific. After some runs all should be installed (usually 2-3 here) sigh
copy parts\instance\etc\wsgi.ini to zope.ini.
edit the copied zope.ini and change/ replace section [server:main] with
[server:main]
use = egg:waitress#main
host = 127.0.0.1
port = 8080
start Plone with .\bin\runwsgi.exe -v zope.ini or in debug mode with .\bin\runwsgi.exe -dv zope.ini
Well, if it's freaking you out, with the updated instructions from Vincent Fretin in the package, can we all please imagine how difficult it is for others to update anything in the core Plone frontend story at the moment?
(Trying to overwrite/fix something in the TinyMCE pattern today myself....)
Note that the release is not considered official yet until the Installers are out. But from now on this is the recommended stable version and you should be happy to put it in production.
As always: please first test the install locally or on a test server.
And... there was one last-minute addition. I say last-minute, but it was planned for longer. It is a little gift from the Plone security team. Products.isurlinportal 1.1.0 contains a fix for a small vulnerability. See public bug report here with some more explanation:
When upgrading our largest current project to Plone 5.2.2 I ran into an issue with collective.solr which I fixed by adding a provides attribute to an adapter registration:
From the changelog I could not figure out why this breaks in Plone 5.2.2. I do not have much time right now to investigate but maybe this is helpful for someone...
http://demo.plone.org now runs 5.2.2
Nightly builds for 5.2.x in py2 and py3 and for Plone 6.0 (without Volto) are redone will be available as soon as the DNS switch is done.