Help me a made draft PR

TajAlasfiyaa · March 22, 2023, 9:50am

Edit : you have to read the docs before asking
Hello plone community can you help me with my PR draft and give me tips and advice

this is my first PR

@sneridagh

github.com/plone/volto

Refactor: Delete Class Component from Delete.jsx File

plone:master ← TajAlasfiyaa:refctor_edit_to_hook

opened 09:36AM - 22 Mar 23 UTC

TajAlasfiyaa

+120 -126

Hey team, I've just submitted a pull request that deletes a React class compo…nent and replaces it with a function component. This change should help simplify our codebase and make it easier to maintain going forward. Function components are generally more lightweight and easier to reason about than class components, so this should be a good improvement overall. Please review the changes and let me know if you have any feedback or concerns. Thanks for your attention! Best, TajAlasfiyaa Ishag

curiousyuvi · March 22, 2023, 10:10am

Hey @TajAlasfiyaa, I think the maintainers are not accepting PR for Class to functional component changes right now, as this is a GSoC project this year. Mentors could confirm.

TajAlasfiyaa · March 22, 2023, 10:12am

thank you i didn't know that

curiousyuvi · March 22, 2023, 10:17am

I'm happy to help. In the meantime you can contribute to fixing some other issues on Volto.