ebrehault
October 13, 2024, 1:15pm
1
Hello!
That's my first Volto PR, and I think I have carefully followed the guidelines, still I get a failing GitHub action called readme-link-check, complaining about links in README.md (which I haven't changed in my PR).
plone:main ← plone:support-depth-in-nav
opened 04:59PM - 12 Oct 24 UTC
- [X] I signed and returned the [Plone Contributor Agreement](https://plone.org/… foundation/contributors-agreement), and received and accepted an invitation to join a team in the Plone GitHub organization.
- [X] I verified there aren't other open [pull requests](https://github.com/plone/volto/pulls) for the same change.
- [X] I followed the guidelines in [Contributing to Volto](https://6.docs.plone.org/volto/contributing/index.html).
- [X] I succesfully ran [code linting checks](https://6.docs.plone.org/volto/contributing/linting.html) on my changes locally.
- [X] I succesfully ran [unit tests](https://6.docs.plone.org/volto/contributing/testing.html) on my changes locally.
- [X] I succesfully ran [acceptance tests](https://6.docs.plone.org/volto/contributing/acceptance-tests.html) on my changes locally.
- [X] If needed, I added new tests for my changes.
- [ ] If needed, I added [documentation](https://6.docs.plone.org/volto/contributing/documentation.html#narrative-documentation) for my changes, either in the Storybook or narrative documentation.
- [X] I included a [change log entry](https://6.docs.plone.org/contributing/index.html#contributing-change-log-label) in my commits.
-----
I am not fully satisfied with the unit test I have added as it only checks the new `depth` parameter is accepted but it is not checking how deep is the obtained nav tree.
The thing is I was not able to created nested contents in the unit test (I tried `createContent` with `path: '/news'` but it was failing).
Thanks
davisagli
October 13, 2024, 3:24pm
2
The documentation build checks all links. Sometimes there are transient problems because a server is unreachable. That looks like the case here, so I re-ran the job.
