Do I need to close and resubmit my pull request?

Development Developing for Plone
1

Hi,

I read the contribution guidelines for Plone and knew I was supposed to update the change log with each pull request, however I didn't know I had to specifically update the change log right before making my pull request at https://github.com/plone/Products.CMFPlone/pull/1998.

I updated the change log afterwards. The Changelog verifier still says "No entry found!", so do I need to delete and resubmit my pull request, or can someone override this? I'm new and still figuring things out here, thanks for any help.

2

You need to update the same pull request rather than creating a new one. So create a new commit on the same branch you made your changes and push. That would be enough.

Thanks for contributing!

1 Like
3

Thanks @gforcada! Just created and pushed the new commit. :smiley: