Classic UI minor clean up

Development Accessibility
1

There are a couple minor discrepancies/issues my team noticed in the classic UI with regard to hiddenStructure elements. I submitted an issue for one of them, but them seem related. Before I put in issues/PRs for the rest I would like to ask if there is any reason for them to exist? They mess with the tab order, and do not seem to provide any extra functional for sighted or not-sighted people. Are they perhaps vestigial remnants from past versions?

The structure in these examples is pulled from https://classic.demo.plone.org, currently in 6.1

  1. Main search form:
<div class="hiddenStructure" id="portal-advanced-search">
      <a href="https://classic.demo.plone.org/@@search">Advanced Search…</a>
    </div>
  1. Navigation portlet header:
<div class="card-header hiddenStructure">
      <a class="tile" href="https://classic.demo.plone.org/en/sitemap">Navigation</a>
    </div>
  1. Event page, a hidden list:
<ul class="hiddenStructure">
              <li><a class="url" href="https://classic.demo.plone.org/en/demo/an-event" itemprop="url">https://classic.demo.plone.org/en/demo/an-event</a></li>
              <li class="summary" itemprop="name">An Event</li>
              <li class="dtstart" itemprop="startDate">2024-09-30T00:00:00+02:00</li>
              <li class="dtend" itemprop="endDate">2024-10-06T23:59:59+02:00</li>
              <li class="description" itemprop="description">Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus. Maecenas sed diam eget risus varius blandit sit amet non magna.</li>
            </ul>
1 Like
2

I think that these are leftovers, you can safely remove them. Search is already available in head link rel="search", sitemap belong to the footer and it is ok for accessibility to just have a link to the sitemap, events has no particular place but existing tags are already semantic, Plone events are recognized by search engines like Google as an extra info in the page.

3

For what it's worth, this is what our accessibility guy flagged as a problem:

When navigating through links with a keyboard, the focus does not follow the same order as the visual layout of the page suggests. This issue is a violation of Success Criterion 2.4.3 in WCAG 2.0

I don't quite follow why that is a problem, but it sounds like it's worth removing if they no longer serve a function.