Archetypes unable to clear date field values

seanupton · July 21, 2016, 12:05am

AT DatetimeWidget in Plone 5 (Products.Archetypes 1.10.x+) and in plone.app.widgets 1.x will not empty any existing set date/time value.

This is the culprit:

github.com

plone/Products.Archetypes/blob/6ef4a03d6193660546380c7cfb6d5f7bea5f0b8d/Products/Archetypes/Widget.py#L1106



def process_form(self, instance, field, form, empty_marker=None):
    """Basic impl for form processing in a widget"""

    value = form.get(field.getName(), empty_marker)
    if value is empty_marker:
        return empty_marker

    tmp = value.split(' ')
    if not tmp[0]:
        return empty_marker
    value = tmp[0].split('-')
    if len(tmp) == 2 and ':' in tmp[1]:
        value += tmp[1].split(':')
    else:
        value += ['00', '00']

    try:
        value = DateTime(datetime(*map(int, value)))
    except:
        return empty_marker

I'm fixing this on a fork or plone.app.widgets 1.x (PR soon), as such:

Fixing this for Plone 5 in Products.Archetypes master seems reasonable, but should I submit this as a pull request (with fix plus test) or just as an issue?

Sean

jensens · July 21, 2016, 5:58am

Pull requests are very welcome.