Continuing the discussion from Using GitHub's Marketplace tools to check add-ons code quality:
according to ESLint:
I want to ask what's our choice? can we stick to single quotes like we do in Python code?
to stick on single quotes I have added the following configuration file for the linter:
I'm +1 for this.
I'm starting using this eslint config and also a prettier config to force the use of single quotes in new projects.
Just some food for thought:
- The JSON standard requires double quotes and does not allow single quotes
- Prettier uses double quotes by default: https://prettier.io/docs/en/options.html#quotes
- plone-react uses single quotes: https://github.com/plone/plone-react/blob/master/package.json#L308
No opinion either way. It is complicated...
IMO, we should use single quotes as that's what we're used to in Python.
Just wondering if any final decision was made on this.
I found a plip that is requesting to use black as our python formatter, which means double quotes instead of single quotes for python code.
I looked at the styleguides, but that seems to not specifically talk about this: https://docs.plone.org/develop/styleguide/
except for here: https://docs.plone.org/develop/styleguide/python.html#quoting
which is not black consistent
Would it then not be more consistent to use double quotes everywhere at this point in time?
Or are the js developers all in favor of single quotes.
I would like this to see the quotes used consistently across plone and js, but that's just my personal opinion.