[plone.app.querystring/Collection] "within last N days" translated to "largerThanRelativeDate"

zopyx · June 25, 2020, 12:55pm

Plone 5.2.1

Creating a collection criteria with effective date "with last" 365 days is stored internally as

[{'i': 'effective', 'o': 'plone.app.querystring.operation.date.largerThanRelativeDate', 'v': '365'}]

which seems incorrect. The stored query sounds like 365 days in the future.

Looks as if something is mixing up future and past in the criteria UI here!?

zopyx · June 25, 2020, 1:07pm

Sidenote: within a migration we transform an old-style date criterion with operation less into lessThanRelativeDate (using Plone's own migration code for topics).

jaroel · June 25, 2020, 3:00pm

It can be bit confusing:

github.com

plone/plone.app.querystring/blob/master/plone/app/querystring/queryparser.py#L193-L224


def _lessThanRelativeDate(context, row):
    """ "Between now and N days from now." """
    # INFO: Values is the number of days
    try:
        values = int(row.values)
    except ValueError:
        values = 0
    now = DateTime()
    start_date = now.earliestTime()
    end_date = now + values
    end_date = end_date.latestTime()
    row = Row(index=row.index,
              operator=row.operator,
              values=(start_date, end_date))
    return _between(context, row)




def _moreThanRelativeDate(context, row):
    """ "Between now and N days ago." """
    # INFO: Values is the number of days

This file has been truncated. show original

We're filtering on dates here, where the effective date needs to be larger then the date relative to the current date - the number of days given.
Granted, it probably would have been better if it would store -365, but then you'd need to convert it in the frontend to make it displayable for the user.

note: I typed this in myself back in the day and it hurt my brain.

zopyx · June 26, 2020, 7:53am