Plone.api PR test problems

Hi,

Both PRs for plone.api (https://github.com/plone/plone.api/pull/327 and https://github.com/plone/plone.api/pull/328) have Plone Jenkins CI - pull-request-5.x checks failing.
Why are they failing? And if these checks don't matter, could someone review the PRs?

Cheers,
-Roel

Given that plone.api is forbidden in core, they probably do not matter, and mr.roboto should exclude it...

I will have a look at both PRs. Thanks for submitting them!

Other opinions?

plone.api should not be used by other core packages, but it is itself part of Plone core and I think we should make sure that its tests continue to pass as changes are made to the underlying Plone code it uses. So -1 for excluding it.

1 Like