@esteele Great!
We need to rebuild mockup + plone bundles + add upgrade steps.
I am working on that - will have PR's today.
@fredvd It seems p.a.contenttypes has been released and included in 5.1.x
So this will cause breakage of case A) mentioned above?
If this gets into Plone 5.1.4. Jup. It's a catch 22: If we fix the marker interface in the templates and release a plone.app.mosaic 2.2 then it will no longer work with Plone < 5.1.4 if people only update plone.app.mosic. The other way around we can update plone.app.mosaic pin in ecosystem section in versions.cfg of Plone 5.1.4 but most releases will define their own pinnings and not depend on ecosystem.
If the people who merged the marker interface changes in plone.app.contenttypes could advise on how to support both interfaces in other packages with Plone >= 5.1.4..... It seems to have a big impact for a change in a 5.1.X point release.
I just tried upgrading a real data.fs to coredev 5.1.x x- and the problem discussed above break my existing contentypes - newsitems for instance - the behaviors ILeadImage and IRichText are gone.
Easy to apply the new ones, though, but shouldnt we have migration steps for this?
@iham you did the implemenation, any thoughts on this?
My proposal for fixing the plone.app.contenttypes richtext behavior problems: create a branch 1.x and use that in 5.1. See https://github.com/plone/plone.app.contenttypes/pull/480#issuecomment-425452682
Plone 5.1.2 is still so buggy. I had to use Plone as editor today for fixing migration issues. Using Plone as an editor is so frustrating and partly humiliating due to tons of minor or major usability bugs.
See issues #2528-2536 that I filed today. Are we still in the "enterprise" world? Is this the "digital experience" for content editors? Plone is getting more and more an unmaintained and unmaintainable piece of kludge.
I've got a prerelease of 5.1.4 ready, see https://community.plone.org/t/plone-5-1-4-soft-released/. Can you all confirm that your fixes made it in?
@sunew is the folder contents bug https://github.com/plone/Products.CMFPlone/issues/2395 solved now? Ticket(s) are still open.
Fred's fix from Fix folder layout property migration by fredvd · Pull Request #484 · plone/plone.app.contenttypes · GitHub was added in 1.4.12 but got lost in 1.4.13. That one should have stayed in. Could you fix that?
I made a PR: Fix folder layout property migration by mauritsvanrees · Pull Request #494 · plone/plone.app.contenttypes · GitHub
1 Like
Thanks. I've merged and released that.
1 Like
@esteele We are about to merge https://github.com/plone/Products.CMFPlone/pull/2563/files
and https://github.com/plone/plonetheme.barceloneta/pull/165
Good canditates for inclusion in 5.1.4
Finally we need a rebuild of the cmfplone bundles - we should do that just before the release.
When do you plan on releasing final?
@agitator https://github.com/plone/Products.CMFPlone/issues/2395
I can confirm it is fixed.
But to make the changes take effect we need to delete the bundles in portal_resources/resource_overrides/production/ and rebuild (by going to @@resourceregistry-controlpanel and enabling and disabling dev mode or by running the GS CMFPlone:dependencies "Bundle combination" step in portal_setup).
There are tickets for this upgrade problem (one of them is https://github.com/plone/Products.CMFPlone/issues/2032 ).
We are working on a solution for this today.
1 Like
@esteele The breaking behavior change in plone.app.contenttypes that was supposed to have been reverted in 1.4.13, was not actually reverted. Probably some misunderstanding. See this comment. I have made PRs to fix it. See https://github.com/plone/plone.app.contenttypes/pull/496
Those should be included in 5.1.4 final.
1 Like
@esteele Please include plone.app.contenttypes 1.4.15 and plone.app.discussion 3.0.8. And we need a new rc for CMFPlone (just a test fix).
Thanks for catching/fixing that. I've added those to the release.
1 Like