Mockup 1.x / plone.app.widgets 1.x

seanupton · June 10, 2016, 9:19pm

Folks,

I am backporting some existing mockup 2.x changes to mockup 1.x branch (on a fork) for my use in plone.app.widgets 1.x (also on a fork). My aims:

More widget parity in Plone 4.x and 5 as part of an incremental UX strategy to familiarize my users in a transition toward Plone 5.
Use portal_type in lieu of Type
Updated fixes for some misc. things in related items pattern that do not work well in 1.x branch.
Updated TinyMCE pattern.

Any thoughts about merits of pull requests once I'm done on my forks? Or pitfalls I should be aware of?

Sean

vangheem · June 11, 2016, 2:16am

I think it's definitely fine to provide a PR.

The only potential pitfalls will be changes that would also need to be made to plone.app.widgets for any options that have changed.

fredvd · June 11, 2016, 9:33am

Ongoimg support for these technologies in Plone 4 would be very welcome.

I've steered away so far from using p.a.widgets in existing Plone 4 projects because the 1.X versions for the previous Plone versions tend to go unmaintained after the release of the next major Plone version where the new feature / technology is default instead of 'experimental'.

Fred

thet · June 11, 2016, 12:23pm

@seanupton Please use mockup 2.x in plone.app.widgets 1.x as I do. I use mockup 2.x in a own integration package. No problem with that - mockup 2.x changes were mostly due to bring it closer to patternslib.
Maybe it's useful (but I don't think necessary) to backport some plone.app.z3cform changes to plone.app.widgets.

seanupton · June 12, 2016, 3:35am

I was doing this earlier, but trying to bring the 1.x branch to some stability first. I submitted a pull request with very recent 2.x build that I subsequently closed when confused about appropriateness of this. Currently, the unreleased plone.app.widgets 1.x now has a broken mockup 2.x circa early April (missing a link modal fix you made on mockup master April 5, IIRC).

There were a few other things I was experiencing with mockup 2.x in Plone 4 that were unexpected (broken form tabbing, in some cases), but I have not yet tracked down whether that was integration specific on my end.

I am happier to move plone.app.widgets 1.x branch to mockup 2.x if there is even a hint of consensus to do so. And I can invest as much effort as I need to over coming 1-2 weeks to make this work, and work well.

Sean

seanupton · August 11, 2016, 4:30pm

There were a variety of small Mockup 2 compatibility fixes, and other fit-and-finish improvements I saw necessary to build upon, especially for TinyMCE and Related Items patterns. I have also renamed next unreleased version to 1.9.1 (since this is mostly just fixes for 1.9 integration of latest mockup) -- all of this can be reviewed in the following pull request for the 1.x branch:

github.com/plone/plone.app.widgets

Numerous Mockup 2 compatibility fixes for 1.x branch, plus semver and TinyMCE fixes

plone:1.x ← upiq:1.x

opened 05:03AM - 11 Aug 16 UTC

seanupton

+175 -72

- Possible to use Rich Text (TinyMCE 4, properly configured) pattern in Dexter…ity types other than plone.app.contenttypes implementation, with consistent behavior with other uses of TinyMCE on Plone 4 sites. This is useful for Plone 4 sites wanting to use plone.app.widgets wthout requiring plone.app.contentypes. - Update README with notes regarding rich text widget. - Update widgets bundle to the latest (2.3.0 - unreleased, 2016-08-18). This includes minor widget improvements for related items widget, for icon compatibility with Plone 4, and button display style. It also fixes progress bar styles for upload pattern as used in TinyMCE. - Now possible to clear Archetypes date/time field value, replacing any previous value with empty value, when desired for both date and datetime. - TinyMCE folder context adjusted appropriately for use in static text portlet: uploads now work, browsing now starts at appropriate root. - Expose alternate RichTextFieldWidget factory, not tightly bound to plone.app.contenttypes, when plone.app.contenttypes is not installed. This may be useful for use by static text portlet, other Dexterity content types on sties where plone.app.contenttypes is not in use. - Enable pasting of foreground, background color if and only if the foreground and background color toolbar buttons are enabled for editing. - Browser spell check enabled by default; this is usually desired for most editing, and low-risk. Users can use Shift + right-click (Firefox) or Control + right-click (Chrome) to show correction suggestions. - Related items options computes context for all z3c.form based forms, not just add forms. This is congruent with how plone.app.widgets 2.0.4+. - Omit 'folderTypes' parameter from configuration of related items widget. This is no longer used by mockup 2.x. - Related items data converter supports explicit value_type specified in field when using collections of UUID values. This is backward-compatible with previous conversion to field values, supports str/unicode value(s), whichever is specified by field (backported from related change to plone.app.z3cform 2.0.1).

If you are using Plone 4 with plone.app.widgets, I strongly recommend trying these. Contained are fixes for TinyMCE in static text portlet, related items fixes, ability to use Related Items in any context-bound z3c.form context (not just add/edit), and a few other minor things.

My only current known outstanding UX issue with this integration is broken progress bar on TinyMCE uploads (this is likely only a CSS omission).

Sean