Working on fixing some issues with the futureimperfect theme.
Here's my pull request https://github.com/collective/plonetheme.future_imperfect/pull/5
@tkimnguyen I see you've done some work on this, please take a peek.
2 Likes
Many thanks for the fixes!
Now that I'm digging into the theme there are other things that need attention. I'll see if I can add a few more bug reports.
At a glance it feels like it could do with 15 - 20 hours of attention. I have concerns about spacing of the columns and there is some "leakage" of the frontend CSS that's causing issues with the admin interface.
A simple example is the lack of space between portlets and the body.
By contrast, the original theme has lots of space between the sidebar and the body..
1 Like
This is an example of a "leakage" I found. I'll make some fixes myself whenever I get the chance.
Sorry... should have said... you're welcome!
1 Like
Made a few minor changes myself this weekend, and found some more bugs I plan on working on later. Submitted a pull request at https://github.com/collective/plonetheme.future_imperfect/pull/7.
- Added spacing on full width pages.
Before:
After:
- Removed the dotted active link leaking into the button, and added spacing between buttons and table
Before:
After:
1 Like
Wow, @vicodin is fast! Already merged my previous pull request. 
I just submitted another pull request to fix an issue for mobile users, thanks to @pigeonflight for pointing it out: https://github.com/collective/plonetheme.future_imperfect/pull/8
Before:
After:
2 Likes