Batch sizes in views

espenmn (Espen) 2019-05-16 19:35:48 UTC #1

If one wants to change ALL places batch it 20 to 40-50 (folder listing, summary view, table listing etc, search results etc.): Is this scattered 'all around' or just a few places … plone.app.contentlisting maybe ?

djay (Dylan Jay) 2019-05-17 02:51:21 UTC #2

I don't know the answer but its something I've wondered myself. Its one of those things that should be a control panel setting.

erral (Mikel Larreategi) 2019-05-17 05:50:49 UTC #3

Each time you create a batch in python code you need to set the size of that batch:

github.com

plone/Products.CMFPlone/blob/master/Products/CMFPlone/PloneBatch.py#L10


# -*- coding: utf-8 -*-
from ZTUtils import make_query


from plone.batching.batch import QuantumBatch
from plone.batching.utils import calculate_pagerange


from zope.deprecation import deprecated




class Batch(QuantumBatch):


b_start_str = 'b_start'


def __init__(self, sequence, size, start=0, end=0, orphan=0,
             overlap=0, pagerange=7, quantumleap=0,
             b_start_str='b_start'):
    super(Batch, self).__init__(sequence, size, start,
                                end, orphan, overlap,
                                pagerange, quantumleap)
    self.b_start_str = b_start_str

So you need to change all around.

When using Collections, you can set the batch size directly in the collection options, so I guess you can patch it to provide a different default value for the batch size. But this would work only for collections.

espenmn (Espen) 2019-05-20 09:57:16 UTC #4

Looks like 'quite a lot' is defined in plone.app.contenttypes

I made this if it should be of any interest: https://github.com/espenmn/medialog.batchsize

It adds a control panel where you can set batch size for some common views and also an option to hide items that are marked 'exclude_from_nav'.

Unfortunately, I found no way to avoid duplicating the templates ( is it possible to link to templates from another add-on ?)

erral (Mikel Larreategi) 2019-05-20 10:27:05 UTC #5

In ZCML you can do:

<configure ....>
     <configure package="plone.app.contenttype.browser">
                <browser:page
                          for="Products.CMFPlone.interfaces.IPloneSiteRoot"
                          class=".folder.FolderView"
                          layer="medialog.batchsize.interfaces.IMedialogBatchsizeLayer"
                          permission="zope2.View"
                          template="templates/listing.pt"
                />
     </configure>
</configure>

And the relative things (either class or template) are taken from the package stated in the configure tag, so I guess you can use something like that but pointing to your class (with the full dotted name).

djay (Dylan Jay) 2019-05-20 11:05:38 UTC #6

please please just put it in a PR for base plone. save everyone the pain of dealing with later.

espenmn (Espen) 2019-05-20 12:13:56 UTC #7

I took a look in /portal_view/customization, and there are LOADS of duplicate view(names )s, so I am not sure how smart it is to add this without a proper plan (suddenly there is one view that uses default 20 anyway).

PS: I can add a PR, but what about adding it for just plone.app.contentypes ?

Code of Conduct – Hosting courtesy of Rackspace