Add field to existing Fieldset in inherited Behavior?

jensens · September 15, 2014, 11:03am

We tried to inherit from IPublication behavior as a replacement for the default behavior and put a new field on the dates tab. Now if we put the fieldset in there two Dates tabs are showing up (IPublication is disabled).

How can we have only one tab?

github.com

bluedynamics/fieldset.bug/blob/master/src/fieldset/bug/behaviors.py

# -*- coding: utf-8 -*-
from plone.app.dexterity import PloneMessageFactory as _PMF
from plone.app.dexterity.behaviors.metadata import IPublication
from plone.autoform import directives as form
from plone.autoform.interfaces import IFormFieldProvider
from plone.supermodel import model
from z3c.form.interfaces import IEditForm, IAddForm
from zope import schema
from zope.interface import provider


@provider(IFormFieldProvider)
class IFieldsetBugBehavior(IPublication):
    """
    """

    # dates fieldset
    model.fieldset(
        'dates',
        label=_PMF(u'label_schema_dates', default=u'Dates'),

This file has been truncated. show original

Or is this a bug as my junior dev thinks?

jaroel · September 15, 2014, 11:39am

This creates a different class, thus a different field (IFieldsetBugBehavior.dates and IPublication.dates).

I don't know why the IPublication.dates field is still in the fieldset. Are you really really sure the IPublication behaviour is disabled?

jensens · September 15, 2014, 11:46am

Yes. Its disabled.
If you dont believe it: Clone the git-repo local, buildout, create plone with dx types and add the behavior TTW to a portal-type of your choice and remove the default IPublication.
Then add the type and look at the tabs.

datakurre · September 15, 2014, 1:14pm

@jensens I believe, you are doing everything right and that's a bug. I created a pull request, which seems to fix your issue and does not seem break any tests (at least in plone.autoform).

jensens · September 15, 2014, 1:30pm

yeah, cool! thanks for that.